Websites Discussion

Talk about our websites Serato.com and Whitelabel.net
To talk about a Serato product such as Scratch Live or ITCH please find the appropriate forum area.

Broken Quote

nik39 5:32 PM - 7 January, 2011
Quote me
nik39 5:32 PM - 7 January, 2011
Quote:
Quote me
nik39 5:32 PM - 7 January, 2011
Quote:
Quote:


Quote me
nik39 5:32 PM - 7 January, 2011
Quote:
Quote:


Quote:




Quote me
nik39 5:32 PM - 7 January, 2011
Quote:
Quote:


Quote:




Quote:






Quote me
nik39 5:33 PM - 7 January, 2011
(u
nik39 5:33 PM - 7 January, 2011
I think you get the picture...Using the "QUOTE" link/button.
nik39 5:34 PM - 7 January, 2011
;)
Serato
dave 1:30 AM - 10 January, 2011
Ha, yep, nice one nik. I logged that in our system last week :)
2:22 AM, 10 Jan 2011
Discussion locked by dave
2:22 AM, 10 Jan 2011
Discussion unlocked by dave
Serato, Forum Moderator
Eru G 11:32 PM - 13 April, 2011
Sorry it's taken so long, but this bug finally got annoying enough for me to look into it ;)

Should be fixed now
nik39 11:33 PM - 13 April, 2011
Quote:
Quote:
Quote:
Quote:
Quote:
Quote me
nik39 11:35 PM - 13 April, 2011
Hm, are you sure it's fixed? It should have come out like this:

Quote:
Quote:

Quote:


Quote:



Quote:
Quote me
Serato, Forum Moderator
Eru G 11:37 PM - 13 April, 2011
Quote:
Quote:
Quote:
Quote:
Quote:
Quote:
Quote me


Works ok for me - what browser are you using again Nik ?

Edit: Oh, sorry, I misread your post.

How did you conclude it should come out like that ?
nik39 11:41 PM - 13 April, 2011
If you quote this post: serato.com

Then it should *not* add an additional CR/LF to the outer quoting. It should *not* touch/alter the inner quotings. Does that make sense?
Serato, Forum Moderator
Eru G 11:47 PM - 13 April, 2011
*sigh* sorry, I'm not switched on at the moment. I see what you mean.

As you can see from the new quoting behaviour, I've trimmed any excess space between the message and the quote, rather than stopping extra spaces being inserted. This just helps keep requoting from going insane again IMO.

If you look at it from the point of stopping nested quotes from making the forum look like an unreadable mess of whitespace, I think this implementation addresses that, which is what I'm most concerned about at this point. If it becomes a problem, we can look at it again.
nik39 11:52 PM - 13 April, 2011
My point is still that you should not alter the original message. This is how the quoting also worked previously before it got broken.
Serato, Forum Moderator
Eru G 11:59 PM - 13 April, 2011
Quote:
My point is still that you should not alter the original message. This is how the quoting also worked previously before it got broken.


And after a quick tweak, is how it will actually behave. That makes more sense than my awful rationale.

Note to self: Don't try code bugfixes after cake and energy drinks :P
nik39 12:01 AM - 14 April, 2011
Nice one. Thanks for the quick fix (well, the fix for the fix was quick, not the initial fix itself ;) ).

Cake... Was it one of the famous Brigid-cakes? :)
Serato, Forum Moderator
Eru G 12:07 AM - 14 April, 2011
Quote:
Cake... Was it one of the famous Brigid-cakes? :)


Not this time, but that won't stop me :P
Serato
dave 2:51 AM - 14 April, 2011
Quote:
My point is still that you should not alter the original message. This is how the quoting also worked previously before it got broken.

I disagree, trimming the whitespace is the better solution, and a perfectly acceptable one.
nik39 5:13 AM - 14 April, 2011
Trimming whitespace is a weird functionality, esp at the beginning og the line. Formatting and ascii art is difficult when leading white space are killed ;)
Serato
dave 9:15 AM - 14 April, 2011
Quote:
Formatting and ascii art is difficult when leading white space are killed ;)


Like this portrait of me wearing white in a blizzard?
Quote:




















nik39 1:19 PM - 14 April, 2011
Once I adjusted the contrast it was okay :-P

`````````````````````_````````
``___``___`_`__`__`_|`|_`___``
`/`__|/`_`\`'__/`_``|`__/`_`\`
`\__`\``__/`|`|`(_|`|`|_`(_)`|
`|___/\___|_|``\__,_|\__\___/`
``````````````````````````````
``_`````
`(_)___`
`|`/`__|
`|`\__`\
`|_|___/
````````
``````````````````
````````````##````
`##`````````##````
#####``###``##`#``
`##```##`##`#####`
`##```##`##`##`##`
`##```#####`##`##`
`##```##````##`##`
``###``####`##`##`
``````````````````
`.o8``````````````````````````````.``````````````````````````.```
"888````````````````````````````.o8````````````````````````.o8```
`888oooo.```.ooooo.```.oooo.o`.o888oo``.ooooo.```.oooo.o`.o888oo`
`d88'``88b`d88'``88b`d88(``"8```888```d88'``88b`d88(``"8```888```
`888```888`888ooo888``"Y88b.````888```888ooo888``"Y88b.````888```
`888```888`888````.o`o.``)88b```888`.`888````.o`o.``)88b```888`.`
``Y8bod8P'``Y8bod8P'`8""888P'```"888"``Y8bod8P'`8""888P'```"888"`
`````````````````````````````````````````````````````````````````
`````````````````````````````````````````````````````````````````
`````````````````````````````````````````````````````````````````

(courtesy of www.asciiarts.net )
DJ Stoyvo 7:56 PM - 16 May, 2011
Quote:
Once I adjusted the contrast it was okay :-P

`````````````````````_````````
``___``___`_`__`__`_|`|_`___``
`/`__|/`_`\`'__/`_``|`__/`_`\`
`\__`\``__/`|`|`(_|`|`|_`(_)`|
`|___/\___|_|``\__,_|\__\___/`
``````````````````````````````
``_`````
`(_)___`
`|`/`__|
`|`\__`\
`|_|___/
````````
``````````````````
````````````##````
`##`````````##````
#####``###``##`#``
`##```##`##`#####`
`##```##`##`##`##`
`##```#####`##`##`
`##```##````##`##`
``###``####`##`##`
``````````````````
`.o8``````````````````````````````.``````````````````````````.```
"888````````````````````````````.o8````````````````````````.o8```
`888oooo.```.ooooo.```.oooo.o`.o888oo``.ooooo.```.oooo.o`.o888oo`
`d88'``88b`d88'``88b`d88(``"8```888```d88'``88b`d88(``"8```888```
`888```888`888ooo888``"Y88b.````888```888ooo888``"Y88b.````888```
`888```888`888````.o`o.``)88b```888`.`888````.o`o.``)88b```888`.`
``Y8bod8P'``Y8bod8P'`8""888P'```"888"``Y8bod8P'`8""888P'```"888"`
`````````````````````````````````````````````````````````````````
`````````````````````````````````````````````````````````````````
`````````````````````````````````````````````````````````````````

(courtesy of www.asciiarts.net )